docs(README): add "pre-commit install --hook-type commit-msg" command #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add pre-commit as dev-dependecy? |
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 34 34
Lines 942 942
=======================================
Hits 901 901
Misses 41 41
Continue to review full report at Codecov.
|
|
Having dev dependencies on poetry really makes me wanna ditch pip. |
|
It seems we'll need to change the lowest python version from 3.6 to 3.6.1 to add pre-commit as dev deps. If that's ok, I can add it. |
Lee-W
force-pushed
the
fix-pre-commit-config-doc
branch
from
25fee0a to
cfac0b3
Compare
|
Nice! |
Lee-W
force-pushed
the
fix-pre-commit-config-doc
branch
from
28bcd1c to
2133992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to pre-commit section
(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)
Types of changes
Please put an
xin the box that appliesDescription
docs(README): add "pre-commit install --hook-type commit-msg" command
ci: rename scripts/reformat as scripts/format
Checklist:
./script/reformatand./script/testlocally to ensure this change passes linter check and testSteps to Test This Pull Request
None
Expected behavior
None
Related Issue
If applicable, reference to the issue related to this pull request.
Additional context
Add any other context or screenshots about the pull request here.